Info

Source on GitHub

https://github.com/koinov/ton-staking

Smart Contract Address

EQCg-1FCGMirisq6Hu21Yzhr-5FrI03XJ3UAhavtOyvUczGY

Testing and Issues

You can test this entry and submit issues during the testing period of the Blockchain Contest, Stage 2: Bonus Prize contest.

Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.

Voting

3

Comments

ProofVault.io - non-custodial staking pool for TON, chosen by p2p.org for further development and building production solution. 

ProofVault is an excellent example of DeFi, implementing investment facility based on mutual mistrust. The main feature is - the pool operator doesn't have an access to participants grams and is rewarded by incentive fee only depending on performance.

Dashboard provides users with comprehensive information and allows subscription and redemption to be performed by any TON wallet just by sending text commands.

https://proofvault.io - landing page
https://dashboard.proofvault.io - dashboard
https://youtu.be/AsqVEr8w1dk - rather provocative metaphorical cartoon explaining staking process.


All issues found by judges are fixed. Especially I would mention linked contracts code verification.
Updated Pool contract address : EQBYMwMOhBc3JOSEq6aXv7RdCDnuQEoegau5ybBPZnWHO/yC
You have not added any comments yet...
by rating

Issues

Eager Cobra Apr 27, 2020 at 13:38
WEB SCORE: 2.66
Opening Section – 2
Concept Explained – 3
Language – 3
Classic ICO template. The opening could use a quick and snappy explanation of the concept. Overall, the concept could be explained better by adding illustrations/diagrams and more focused descriptions. All texts could benefit from a thorough proofreading by a native speaker.

VIDEO SCORE: 1.58
Narration – 0
Visualization – 3
Concept Explained – 1
Bonus: Soundtrack +0.25
With no narration to help viewers interpret the video, its meaning becomes dangerously vague.

=====
Base Reward: EUR 2,500

OLD BUGS FIXED: 2/3

NEW CRITICAL ISSUES:
Nominator code is incompatible with pool code. Pool never sends 0x4e73744b (process_stake) and 0x47657424 (process_recover_stake_request) messages to nominators. Withdrawal isn't working, because nominator sends 0x534e5254 (TRNS transfer funds to nominator) in process_withdraw_request, which is accepted only from the owner


NEW MINOR ISSUES:
Front-running initialization is still possible. In performance there is no adjusting for transaction_fee. Balance field in nominator is unused.

Bug Penalty: EUR 3,000

======
Total: 0 :(
Mad Crow Apr 27, 2020 at 17:51
Thank you for your review. I'm really sorry, looks like there was a mess with commits while merging core updates and I've lost mentioned changes =(
Nobody added any issues yet...