Info

Download ZIP (7.8 KB)

Testing and Issues

You can test this entry and submit issues during the testing period of the Blockchain Contest contest.

Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.

Voting

33
by time

Issues

Magic Python Oct 16, 2019 at 12:45
accept_message() is called after ALL signatures are checked. It is very likely than it won't be enough gas_credit to handle orders with multiple signatures
2
Kooky Bat Oct 17, 2019 at 20:39
And what is the right way? Probably message should be signed like russian doll, i.e. next sign signs not only the message itself, but also all previous signs. So n-th signature will sign message with all n-1-th signatures. And during the signing client side app can verify all the existing signatures. So server multisig can only verify only the upper level sign, considering others to be valid.
But still, can we trust all the owners of multisig wallet? What if someone will try to cheat and forge other signs, making a message with only one valid signature, and K-1 invalid? I don't see a way the multisig wallet to verify such a message without verifying all of the signatures.
Magic Python Oct 29, 2019 at 17:23
Sadly it didn't work on our test (n=16, k=10).
From README: "Unfortunately I'm not sure if a smart contract is working,
I didn't have enough time to fully test it."
10
Nobody added any issues yet...