You can test this entry and submit issues during the testing period of the Blockchain Contest contest.
Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.
Info
Testing and Issues
Voting
by rating
Issues
plus:
Quite nice and readable code
minus:
Not all features are implemented (merge signatures)
Sadly it didn't work on our test (n=16, k=10).
Quite nice and readable code
minus:
Not all features are implemented (merge signatures)
Sadly it didn't work on our test (n=16, k=10).
As I see accept_message() is called after test of all signatures and by the way if request will have 0 signatures, accept_message() will be called too.
It's probably correct if you add check before accept. But do not move it in loop or I could intercept your message and make list of signatures unimaginably large. And if you throw after accept, I could replay it several times.
Because signatures have to sign seqno, it is impossible to 'send them by email'. But no seqno congestion either, because they can be sent in batches. I think it's a good trade-off.
Because signatures have to sign seqno, it is impossible to 'send them by email'. But no seqno congestion either, because they can be sent in batches. I think it's a good trade-off.
Nobody added any issues yet...