You can test this entry and submit issues during the testing period of the Blockchain Contest contest.
Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.
Info
Testing and Issues
Voting
by rating
Issues
plus:
The code is easy to read.
accept_message() is called after at least one signature was checked.
minus:
Didn't work on our test (n=16, k=10).
`f & (val.preload_uint(32) < curr_ts)` will throw in garbage collect.
seqno is not included in a hash. The same order could be easily executed multiple times.
Not all features are implemented (merge signatures, create a query with multiple signatures)
The code is easy to read.
accept_message() is called after at least one signature was checked.
minus:
Didn't work on our test (n=16, k=10).
`f & (val.preload_uint(32) < curr_ts)` will throw in garbage collect.
seqno is not included in a hash. The same order could be easily executed multiple times.
Not all features are implemented (merge signatures, create a query with multiple signatures)
As I see accept_message() is called after ALL signatures are checked. It is very likely than it won't be enough gas_credit to handle orders with multiple signatures
Nobody added any issues yet...