Info

Download ZIP (8 MB)

Testing and Issues

You can test this entry and submit issues during the testing period of the VoIP Contest, Stage 3. €50,000 contest.

Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.

Voting

Comments

Mindful Pug Apr 2 at 14:20
It's important to highlight the benefits of this solution. In comparing with other submissions, it covers all of them:
1. Competitional quality of audio with the possibility of further improvements (in fact, not all variables were tuned up yet).
2. The codebase is good and 90% ready to deploy into production (Android build, multiple endpoints, data saving mode, TCP endpoints, proxy and so on are supported).
3. Possibility to launch video calls in weeks (thanks to WebRTC it's almost ready).
4. Possibility to launch group calls in weeks (thanks to WebRTC it's almost ready too).
Mindful Pug Apr 16 at 13:17
I've investigated the problem and prepared the solution:
1. You need to apply the small patch for org_telegram_messenger_voip_TgVoip.cpp: https://www.dropbox.com/s/y4wsic3489eu294/jni.patch?dl=1
2. You have to include webrtc/src/out/Android/lib.java/sdk/android/libwebrtc.jar into the final APK; it's also available here: https://www.dropbox.com/s/ru35xeaw87kplmo/libwebrtc.jar?dl=1.

The correct libtgvoip.so in debug mode for the arm platform is available here: https://www.dropbox.com/s/9njgat11iavo061/libtgvoip.so?dl=1
Android armeabi-v7a
You have not added any comments yet...
by rating

Issues

Fair Wombat Apr 26 at 12:07
Успешно справились со всеми заданиями.
Большой объем измненений.
Проактивные доработки: множественные рефлекторы и т д.
Библиотека собралась под Android с небольшим исправлением, успешно работает.
10
Fair Wombat Apr 14 at 11:33
When we build Android version and launch it, the app crashes. Here is stack trace. Can you check if you see any reason for it?

http://paste.debian.net/1140295/
Debian
Mindful Pug Apr 14 at 12:21
Obviously, something goes wrong here: https://chromium.googlesource.com/external/webrtc/+/refs/heads/master/modules/utility/source/jvm_android.cc#71

There (and deeper) some RTC_CHECKs and it's difficult to say for sure where is the problem. Could you rebuild WebRTC by using debug mode (set is_debug=true in build_dependencies.sh)? It should show at least "JvmThreadConnector::ctor" and/or "Attaching thread to JVM" and will give more info for us.
Fair Wombat Apr 14 at 19:18
#issue10972 Here is the log with debug enabled:
http://paste.debian.net/hidden/995e0685/

It seems that check fails here:

JVM* JVM::GetInstance() {
RTC_DCHECK(g_jvm);
return g_jvm;
}

Do you see any easy fix for this?
Debian
Mindful Pug Apr 15 at 11:31
I'm sorry, but I can only give advice blindly because I don't have a way to check it by myself 😕.

You can try to modify org_telegram_messenger_voip_TgVoip.cpp:
1. #include "modules/utility/include/jvm_android.h"
2. Into `tgvoipOnJniLoad` add `webrtc::JVM::Initialize(vm);`
Nobody added any issues yet...