Info
Source on GitHub
Smart Contract Address
kQCTET_RcIaMzlxa8UZCotYYqVeOjG7HSjQ7Z_xeHdpFJSqV
Testing and Issues
You can test this entry and submit issues during the testing period of the Blockchain Contest, Stage 2 contest.
Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.
Voting
by rating
Issues
Nice submission, lotteries are demanded nowadays. Along with Bot it would be very nice. Withdraw limitation is a pain, I would store previous results.
We found some issues in your contract.
Critical:
- The contract ignores existence of processing and storage fees, sending back all funds above 1 gram. It is not evident whether 3% of commission will be enough to cover all the expences. More over, the errors will accumulate and eventually it will be impossible to withdraw all `comsa`, or the `prize_fund` became bigger than contract balance after withdrawing of `comsa`.
Minor:
- "transfer. debug only" operation is not commented out from the code, so owner can steal all the funds.
- There is no check whether chosen numbers belongs to the range 0-99.
- Short time for prize withdrawal and accepting only basechain account can be critical for some use cases.
Critical:
- The contract ignores existence of processing and storage fees, sending back all funds above 1 gram. It is not evident whether 3% of commission will be enough to cover all the expences. More over, the errors will accumulate and eventually it will be impossible to withdraw all `comsa`, or the `prize_fund` became bigger than contract balance after withdrawing of `comsa`.
Minor:
- "transfer. debug only" operation is not commented out from the code, so owner can steal all the funds.
- There is no check whether chosen numbers belongs to the range 0-99.
- Short time for prize withdrawal and accepting only basechain account can be critical for some use cases.
Nobody added any issues yet...