Info

Download ZIP (25.5 KB)

Testing and Issues

You can test this entry and submit issues during the testing period of the Blockchain Contest contest.

Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.

Voting

33

Comments

Desert Falcon Oct 17, 2019 at 15:43
Ёлки палки, забыл добавить в архив файлы stdlib.fc и mylib.fif,
только сейчас вспомнил, а там были доп функции.

Link to the entire archive.
http://complex-soft.com/res/ton2.zip

Link to the "utils".
http://complex-soft.com/res/utils.zip


I forgot to add the stdlib.fc and mylib.fif files to the archive, I just remembered now, and there were additional functions. Attach here.
Where can I send them?
2
You have not added any comments yet...
by rating

Issues

Magic Python Nov 4, 2019 at 10:23
Multisig wallet:
plus:
accept_message() is called only after one signature was verified.
Good perfomance (0.066G for a transfer with n=16, k=10).

minus:
Not all features are implemented (merge signatures)
Single query to add all coowners would work much faster (currently ~0.2G for full initialization)
10
Desert Falcon Nov 4, 2019 at 12:06
minus:
Not all features are implemented (merge signatures)
Single query to add all coowners would work much faster (currently ~0.2G for full initialization)

Спасибо.
Я об этом думал, даже файл назвал (add_coowners) ,но делать не стал. Потому как, в условиях про это ни чего не было сказано).

Thank.
I thought about it, even called the file (add_coowners), but did not do it. Because, under the conditions, nothing was said about it).
Clever Turkey Nov 4, 2019 at 19:06
Manual DNS:
- Only category -1 is supported.
- Maximum domain length is limited by 44 bytes.
- Returns wrong length in case of partial match.
- There is no seqno() method.
- When domain is found, but category is not found the returned length must be non-zero.
- Ability to change code of an inited smart contract is very dangerous.
- Ability to change transaq_id of the smart contract is very-very dangerous.
10
Clever Turkey Nov 4, 2019 at 19:06
365 Automatic DNS:
+ Ability to withdraw earnings.
- No garbage collection for expired domains.
- There is no way to customize domain fees.
- There is no way to customize domain expiration time.
- Ability to change code of an inited smart contract is very dangerous.
- Function send_register_domain is used but not defined.
- recv_internal ignores messages not only from masterchain.
- Maximum domain length is limited by 44 bytes.
- Wrong domain length is returned on partial matches.
- When domain is found, but category is not found the returned length must be non-zero.
10
Huge Giraffe Oct 18, 2019 at 21:00
Manual DNS:
- uses small (352 bit, 44 bytes) max key length in prefix dicts (support up to 1023 bits)
- a lot of extra functionality like send_register_domain
- store_uint(count, 32) in storage is not used anywhere
- supports changing code and seqno - why would anyone trust contract that can change at any moment?
1
Л
Multisig: requires two signatures for any message (even if it adds only one signature to the storage).
Strange check if(num == 0) { accept_message(); } on ln 183. I cant evaluate, whether it may cause problems or just useless
Л
When redirect to child DNS server occurs contract should return length of found domain path. Instead both manual and auto dns return (length+1)*8 of the original query. Thus it is not clear waht query should be sent to child dns.
Magic Python Oct 21, 2019 at 06:40
new_multisig_wallet.fif:4: include: cannot locate file `../utils/mylib.fif`

You may answer this issue with a link to missing files. On github, for example.
Chic Dolphin Oct 22, 2019 at 18:26
If I see it correctly just actual outgoing message is signed by members. So if I collected signatures of it I can execute it as many times as I would like without collecting signatures again.
Nobody added any issues yet...