Info

Merry Croc
Author
Download ZIP (12.2 MB)

Testing and Issues

You can test this entry and submit issues during the testing period of the VoIP Contest, Stage 3. €50,000 contest.

Entries with serious issues will not be able to win the contest, but even minor issues might be important for overall results.

Voting

by rating

Issues

Fair Wombat Apr 13, 2020 at 11:18
Is it possible to provide commits history in order to separate changes? .git folder would do.
Debian
10
Merry Croc Apr 13, 2020 at 12:05
Sure, where should I put it?
Fair Wombat Apr 13, 2020 at 12:09
#issue10968 Dropbox / Google URL drive if it's public, or t.me/dmcatelegram if it's not.
Debian
10
Giant Hare Apr 3, 2020 at 13:21
#issue10959 Answering to your reply: yes, there is a check of `encoder` against `nullptr` before operations on it, but `encoder` is not initialized with `nullptr` in constructor - this pointer just contains garbage before it is set manually with `SetEncoder`, because when you create a raw, non-smart pointer, it is not initialized with `nullptr` unless you do it by yourself, and an uninitialized pointer passes this check in almost every case. You can easily detect the issue with ub- and address-sanitizer - see http://paste.debian.net/1138244/ and http://paste.debian.net/1138246/.
1
Merry Croc Apr 4, 2020 at 16:10
You're right, thank you, learnt a lot while debugging it) It's default initialized in my case. Seems like that's mmap makes it work correctly since I never got an error. Would you share your thoughts?
Giant Hare Apr 2, 2020 at 20:19
The provided library has an issue: member call and access via
uninitialized address (class member `encoder` in `AudioPacketSender`),
and it causes undefined behavior. More detailed description of the issue could be found here http://paste.debian.net/1138113/ because of issue text length restrictions.
Merry Croc Apr 3, 2020 at 11:30
Calls to encoder are protected with checks and encoder is zero initialized. The real issue is that those two calls to UpdateAudioBitrateLimit are taking no effect. I should've remove them since data saving is outside of the Contest scope.
Fair Wombat Apr 26, 2020 at 12:06
Рейтинги ощутимо улучшены.
В начале почти каждого звонка звуки речи повторяются, этого не было в 2.6. Примеры семплов из датасета:

entry1365_sample14_1610bcfe3d4a5409ca90463ea8c0ef8f.pcm_3G2_9398601.wav
entry1365_sample14_9406179a57e6d882cba5a5c23c7e7e4f.pcm_3G2_1948340.wav
entry1365_sample15_03c54b861f72cce82609dd3acbaa85fb.pcm_3G2_6501838.wav
Nobody added any issues yet...